Added the ability to continue without a token#51
Open
KieronWiltshire wants to merge 3 commits intooauthjs:masterfrom
concept-gaming:master
Open
Added the ability to continue without a token#51KieronWiltshire wants to merge 3 commits intooauthjs:masterfrom concept-gaming:master
KieronWiltshire wants to merge 3 commits intooauthjs:masterfrom
concept-gaming:master
Conversation
This allows the ability to explicitly check specific routes.
|
@KieronWiltshire Have you confirmed your change is compliant with the OAuth 2 RFC? Please reference the sections of the RFC that apply to your change. |
Author
|
@markstos it complies with the entire spec, it just allows you to catch the error and continue. |
|
@KieronWiltshire It would be helpful if you linked to the specific spec section that addresses continuing without a token. |
Author
|
@markstos the spec doesn't specify, to be completely honest, this isn't something I need anymore, well not as of right now, so feel free to close this merge request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here at Concept Gaming, we're implementing GraphQL. The setup makes things difficult to work with as GraphQL only exposes data through the use of a single route, this requires us to explicitly check specific end points. I'd greatly appreciate it if this could be merged rather than having us to re-implement it in our application.