Fix URL query parameter decoding in OData V4 plugin#349
Draft
Fix URL query parameter decoding in OData V4 plugin#349
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fix URL encoding issue where '+' characters in query parameters were not being decoded to spaces. This was causing filter and orderBy parameters to be incorrectly parsed (e.g., "value+desc" instead of "value desc"). The fix replaces '+' with spaces before calling decodeURIComponent, following the application/x-www-form-urlencoded format specification. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Apply code review feedback to also replace '+' with spaces in parameter keys before decoding, to handle edge cases where parameter names themselves contain spaces encoded as '+'. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix all issues and initiate build and test
Fix URL query parameter decoding in OData V4 plugin
Feb 4, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OData V4 protocol tests failing on filter and sort operations. Query parameters with spaces (e.g.,
$filter=active eq true,$orderby=value desc) were URL-encoded as+but not decoded, causing parsing failures like"value+desc"instead of"value desc".Changes
packages/protocols/odata-v4/src/index.ts: Replace+with spaces beforedecodeURIComponent()inparseODataQuery()method for both parameter keys and values (application/x-www-form-urlencoded standard)Fixes 4 failing protocol TCK tests. All 126 OData V4 tests now pass.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.com/usr/local/bin/node node /home/REDACTED/work/objectql/objectql/apps/site/node_modules/.bin/../next/dist/bin/next build(dns block)/usr/local/bin/node node /home/REDACTED/work/objectql/objectql/apps/site/node_modules/.bin/../next/dist/bin/next build sh -c tsc git /opt/pipx_bin/node o | grep "physicpnpm(dns block)/usr/local/bin/node node /home/REDACTED/work/objectql/objectql/apps/site/node_modules/.bin/../next/dist/bin/next build uniq k/ob��(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.