fix: CryptoFailedException: Wrapped error/Decryption failed#749
Open
DorianMazur wants to merge 2 commits intomasterfrom
Open
fix: CryptoFailedException: Wrapped error/Decryption failed#749DorianMazur wants to merge 2 commits intomasterfrom
DorianMazur wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #730
Fixes critical decryption failures that occurred with "Authentication tag verification failed" errors by removing the Cipher instance caching mechanism.
Why this change was necessary:
AES-GCM is an authenticated encryption mode that maintains internal state during operation.
Reusing cached Cipher instances for AES-GCM operations causes this internal state to be carried over between unrelated encryption/decryption operations, corrupting the authentication tag verification process.
Performance:
While Cipher instantiation does have some overhead, measurements showed that the cost of creating fresh Cipher instances is negligible compared to the cryptographic operations themselves