Conversation
|
commit: |
Deploying astrobook with
|
| Latest commit: |
cd44884
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6062ffb.astrobook.pages.dev |
| Branch Preview URL: | https://ocavue-deps62.astrobook.pages.dev |
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s dependency set (notably lint/tooling and build tooling), with small follow-up changes in @astrobook/core to accommodate the updated build pipeline and public API typing.
Changes:
- Bumped tooling dependencies (e.g.
@ocavue/eslint-config,tsdown), updatingpnpm-lock.yamlaccordingly. - Updated
@astrobook/corebuild config (tsdown.config.ts) and package metadata (peerDependencies) for Astro usage. - Exposed
IntegrationOptionsfrom@astrobook/core’s public entrypoint and applied a small internal refactor (let→const).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Large dependency graph update reflecting bumped tooling/build deps. |
| package.json | Bumps root dev dependency @ocavue/eslint-config. |
| packages/core/package.json | Adds optional astro peer dependency; bumps tsdown. |
| packages/core/tsdown.config.ts | Adds inlineOnly option for tsdown build. |
| packages/core/src/astro-integration.ts | Re-exports IntegrationOptions type. |
| packages/core/src/index.ts | Exports IntegrationOptions from public entrypoint. |
| packages/core/src/virtual-module/vite-plugin.ts | Minor refactor (let to const). |
| packages/astrobook/README.md | Reorders imports in examples for consistency. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const config: unknown = defineConfig({ | ||
| entry: { | ||
| index: 'src/index.ts', | ||
| client: 'src/client.ts', | ||
| }, | ||
| format: ['esm'], | ||
| clean: true, | ||
| dts: true, | ||
| fixedExtension: false, | ||
| external: [/^virtual:/], | ||
| inlineOnly: ['just-kebab-case'], | ||
| }) |
There was a problem hiding this comment.
defineConfig(...) is being assigned to const config: unknown, which disables type-checking of the config object. Since this change adds a new option (inlineOnly), it would be safer to let TS infer the type or explicitly type the config so typos/unsupported options are caught at build time.
| '@babel/generator@8.0.0-rc.1': | ||
| resolution: {integrity: sha512-3ypWOOiC4AYHKr8vYRVtWtWmyvcoItHtVqF8paFax+ydpmUdPsJpLBkBBs5ItmhdrwC3a0ZSqqFAdzls4ODP3w==} | ||
| engines: {node: ^20.19.0 || >=22.12.0} |
There was a problem hiding this comment.
The lockfile now pulls in pre-release toolchain dependencies (e.g. @babel/*@8.0.0-rc.1). If this is coming from tsdown/rolldown-plugin-dts, it increases the risk of build instability; consider pinning to non-pre-release versions (or adding pnpm overrides) if a stable dependency chain is available.
| '@babel/generator@8.0.0-rc.1': | ||
| resolution: {integrity: sha512-3ypWOOiC4AYHKr8vYRVtWtWmyvcoItHtVqF8paFax+ydpmUdPsJpLBkBBs5ItmhdrwC3a0ZSqqFAdzls4ODP3w==} | ||
| engines: {node: ^20.19.0 || >=22.12.0} |
There was a problem hiding this comment.
Newly added dependencies (e.g. @babel/generator@8.0.0-rc.1) require Node ^20.19.0 || >=22.12.0, but the repo doesn't declare a root engines.node (and there's no .nvmrc/.node-version). This can lead to confusing install failures for contributors on older Node 20.x; consider documenting/enforcing the minimum supported Node version in package.json.
| "yoctocolors": "^2.1.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "astro": "*" |
There was a problem hiding this comment.
@astrobook/core declares astro as an optional peer dependency with version "*", which is inconsistent with the rest of the repo (e.g. packages/types and packages/astrobook use >=4.0.0). Using * can allow unsupported/breaking Astro majors; consider setting an explicit supported range (likely >=4.0.0 to match the other packages).
| "astro": "*" | |
| "astro": ">=4.0.0" |
No description provided.