Skip to content

improve(ui): added confirmation button to DateRanger time selection#1135

Open
linhf123 wants to merge 1 commit intomasterfrom
improve/dateranger-operation
Open

improve(ui): added confirmation button to DateRanger time selection#1135
linhf123 wants to merge 1 commit intomasterfrom
improve/dateranger-operation

Conversation

@linhf123
Copy link
Contributor

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

原先的点击空白进行确定,很容易误触导致抽屉关闭,或者可点击位置过远。增加确定按钮,操作反而简单

Before After
image image

📝 Changelog

Language Changelog
🇺🇸 English added confirmation button to DateRanger time selection
🇨🇳 Chinese DateRanger 添加时间选择确定按钮

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 11, 2025

@dengfuping dengfuping requested a review from wzc520pyfm August 18, 2025 04:18
Copy link
Collaborator

@wzc520pyfm wzc520pyfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改进方案有和我们的设计师做过同步吗?最初去掉【确认】按钮是为了保持简洁,设计上是利用聚焦/失焦的交互来完成输入。
目前存在的交互问题可能让设计师再出一版改进方案?例如增加【确认】按钮或者缩小聚焦范围等。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants