Re-add Rust to Nix flake#191
Closed
TheSuperGamer20578 wants to merge 1 commit intoodilia-app:mainfrom
Closed
Conversation
Member
|
Sorry about the wait—I went on vacation just as you sent this in. |
Member
|
The GH UI made an unverified commit, so I will reopen this with the patch applied. Sorry for the hassle and thank you for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #172 removed
rust-toolchain.toml, it completely removed Rust fromflake.nixrequiring developers who use Nix to have a system-wide Rust installation which defeats the purpose of having a Nix flake. This re-adds Rust to the Nix flake. Since stable is now used, the Cargo package from Nixpkgs can be used directly withoutrust-overlay.I would also suggest removing the caching of
~/.cargo/bin/in the Nix CI since all the Rust toolchain binaries are already retrieved using the flake, however I haven't touched the CI because I didn't want to break anything.