Skip to content

Comments

Bump Rust edition to 2024, MSRV to 1.88.0, and do some cleanup#201

Merged
albertotirla merged 5 commits intoodilia-app:mainfrom
JustSoup312:rust-2024
Jan 5, 2026
Merged

Bump Rust edition to 2024, MSRV to 1.88.0, and do some cleanup#201
albertotirla merged 5 commits intoodilia-app:mainfrom
JustSoup312:rust-2024

Conversation

@JustSoup312
Copy link
Contributor

@JustSoup312 JustSoup312 commented Dec 29, 2025

This MR does the following:

  • Bumps Rust Edition to 2024
  • Bumps MSRV to 1.88.0 as determined by cargo msrv find
  • Fixes rustdoc failing to find cross-doc references
  • Fixes RUSTSEC-2025-0057 in odilia-cache

This MR also runs cargo fmt nad fixes issues found by cargo clippy as recommended by CONTRIBUTING.md

@JustSoup312 JustSoup312 force-pushed the rust-2024 branch 2 times, most recently from 268c147 to a72e293 Compare January 2, 2026 21:22
@JustSoup312 JustSoup312 changed the title Bump Rust edition to 2024, MSRV to 1.85.1, and run clippy and fmt Bump Rust edition to 2024, MSRV to 1.88.0, and run clippy and fmt Jan 2, 2026
@JustSoup312 JustSoup312 changed the title Bump Rust edition to 2024, MSRV to 1.88.0, and run clippy and fmt Bump Rust edition to 2024, MSRV to 1.88.0, and do some cleanup Jan 2, 2026
Signed-off-by: Aster Boese <asterboese@mailbox.org>
@albertotirla
Copy link
Member

the CI check fails with a clippy warning. Can you fix it?

  error: use of `default` to create a unit struct
     --> cache/src/lib.rs:491:46
      |
  491 |         Self { tree: NewCache(HashMap::with_hasher(FxBuildHasher::default())), driver }
      |                                                    ^^^^^^^^^^^^^-----------
      |                                                                 |
      |                                                                 help: remove this call to `default`

@JustSoup312
Copy link
Contributor Author

Should be good now. Missed running clippy after switching hashing crates.

Signed-off-by: Aster Boese <asterboese@mailbox.org>
Signed-off-by: Aster Boese <asterboese@mailbox.org>
Signed-off-by: Aster Boese <asterboese@mailbox.org>
@JustSoup312 JustSoup312 force-pushed the rust-2024 branch 2 times, most recently from c544e03 to 08ce9b1 Compare January 4, 2026 23:07
See https://rustsec.org/advisories/RUSTSEC-2025-0057 for more information.

Signed-off-by: Aster Boese <asterboese@mailbox.org>
@albertotirla albertotirla merged commit 39c4a09 into odilia-app:main Jan 5, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants