Open
Conversation
Collaborator
|
|
Contributor
|
Beginning review now! |
theRealThagomizer
approved these changes
Feb 4, 2026
Contributor
theRealThagomizer
left a comment
theRealThagomizer
left a comment
There was a problem hiding this comment.
Hiya, @erjer-odoo! Looks like this was a quick and easy edit. I had one minor suggestion, just because putting "that" in sentences like this sounds better to my ear. But feel free to take it or leave it. This is approved!
content/applications/inventory_and_mrp/inventory/shipping_receiving/setup_configuration.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: theRealThagomizer <96515928+theRealThagomizer@users.noreply.github.com>
erjer-odoo
force-pushed
the
17.0-inventory-delivery-methods-erjer
branch
from
719ede4 to
41535bf
Compare
Contributor
Author
|
Hi @Felicious -- this PR is ready for final review when you have a moment. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I received a request to take the inventory hardware page and add the information to our help center so it can live alongside our documentation. I've pulled information about the supported label printer from that page and added it to our "Delivery methods" documentation.
This 17.0 PR can be FWP up to master. There will be edits to the 18.0+ FWPs to ensure that certain documentation isn't re-duplicated in the FWPs (some documentation was moved off this page starting in version 18.0), but I will address those FWPs individually and submit an override for the work.