[Pie chart ] Allow color edition for Odoo & Spreadsheet#7794
Open
matho-odoo wants to merge 1 commit intomasterfrom
Open
[Pie chart ] Allow color edition for Odoo & Spreadsheet#7794matho-odoo wants to merge 1 commit intomasterfrom
matho-odoo wants to merge 1 commit intomasterfrom
Conversation
Collaborator
|
|
matho-odoo
force-pushed
the
master-color-pie-chart-matho
branch
4 times, most recently
from
122e102 to
12831a2
Compare
Allows the user to choose the colors of the slices in the design side panel Task: 5347414
matho-odoo
force-pushed
the
master-color-pie-chart-matho
branch
from
12831a2 to
68b35d1
Compare
hokolomopo
reviewed
Feb 5, 2026
|
|
||
| setup() { | ||
| super.setup(); | ||
| this.runtime = this.env.model.getters.getChartRuntime(this.props.chartId) as PieChartRuntime; |
Contributor
There was a problem hiding this comment.
this.props.chartId might (thoeritically) change during the lifecycle of the component. Define a get runtime() {...} instead
Comment on lines
+760
to
+762
| //@ts-ignore | ||
|
|
||
| expect(model.getters.getChartDefinition(chartId).slicesColors).toEqual([ |
Contributor
There was a problem hiding this comment.
Suggested change
| //@ts-ignore | |
| expect(model.getters.getChartDefinition(chartId).slicesColors).toEqual([ | |
| //@ts-ignore | |
| expect(model.getters.getChartDefinition(chartId).slicesColors).toEqual([ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Pie Slice section in Pie chart Design tab
Add a slice selection
Add a slice color selection
Add a slice name edition
Task: 5347414
review checklist