Skip to content

[FIX] Evaluation: Provide cell position on single formula evaluation#7850

Open
rrahir wants to merge 1 commit into18.0from
18.0-fix-partial-evaluation-in-cell-rar
Open

[FIX] Evaluation: Provide cell position on single formula evaluation#7850
rrahir wants to merge 1 commit into18.0from
18.0-fix-partial-evaluation-in-cell-rar

Conversation

@rrahir
Copy link
Collaborator

@rrahir rrahir commented Jan 22, 2026

How to reproduce:

  • in a spreadsheet, go to the last row
  • in a cell of the last row, write the formula =MUNIT(ROW()) -> the formula is in #SPILL error because we did not extend the size of the spreadsheet

Some formulas, like ROW & COLUMN need to know the coordinates of the cell on which they are applied to be computed and we did not provide those in the evaluation context when evaluating isolated formulas.

Task: 5798610

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jan 22, 2026

Pull request status dashboard

@rrahir
Copy link
Collaborator Author

rrahir commented Jan 22, 2026

robodoo up to saas-18.2

@robodoo
Copy link
Collaborator

robodoo commented Jan 22, 2026

Forward-porting to 'saas-18.2'.

How to reproduce:

- in a spreadsheet, go to the last row
- in a cell of the last row, write the formula `=MUNIT(ROW())`
-> the formula is in #SPILL error because we did not extend the size of
the spreadsheet

Some formulas, like ROW & COLUMN need to know the coordinates of the
cell on which  they are applied to be computed and we did not provide
those in the evaluation context when evaluating isolated formulas.

Task: 5798610
@rrahir rrahir force-pushed the 18.0-fix-partial-evaluation-in-cell-rar branch from a5b0a9b to bb48cc2 Compare January 22, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants