[FIX] Evaluation: support ROW/COLUMN in CF and DV#7856
Open
Conversation
Collaborator
|
|
rrahir
changed the title
When evaluating an isolated formula (in CF, DV or in some composer logic, like hovering partial results), we only provide a part of the evaluation context and do not provide the originCell coordinates. This means that some functions (i.e. ROW(), COLUMN()) cannot be computed and therefore used in those contexts. This revision modifies the evaluator so that it can provide an arbitrary cell position to the evaluation context to paliate this issue. Task: 5868662
rrahir
force-pushed
the
19.0-fix-missing-origin-cell-in-isolated-formula-rar
branch
from
a938c9e to
e4dd7f8
Compare
Currently, one cannot use the functions ROW() or COLUMN() in the formula of their conditional format because we lack a crucial point, the 'anchor' cell from which those function compute their value. This revision fixes that situation with some caveat: - 'single color' CF are properly supported - 'color scale' CF have a behaviour that might differ from other spreadsheets Note that computing CF thresholds based on relative values seems like a bad idea to begin with and the results might make sense to some users but not all of them. This revision suggests a behaviour (so that the CF actually yields a result) but does not claim to have proper equivalence with other spreadsheets. Task: 5868662
Currently, one cannot use the functions ROW() or COLUMN() in the rules of their data validations. This revision provides the required cell position to the formula evaluation context to support the evaluation of those functions. Task: 5868662
rrahir
force-pushed
the
19.0-fix-missing-origin-cell-in-isolated-formula-rar
branch
from
e4dd7f8 to
f74c907
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5868662
review checklist