Restore BOARD_RECOVERY_BLDRMSG_OFFSET support#174
Open
Magendanz wants to merge 1 commit intoomnirom:android-7.1from
Open
Restore BOARD_RECOVERY_BLDRMSG_OFFSET support#174Magendanz wants to merge 1 commit intoomnirom:android-7.1from
Magendanz wants to merge 1 commit intoomnirom:android-7.1from
Conversation
The BOARD_RECOVERY_BLDRMSG_OFFSET variable is still needed to set bootloader control block (BCB) offset for command-line arguments in the /misc partition on some configs, notably Rockchip devices. However, the code to convert it to the precompiler directive was removed. This restores it in an appropriate context.
panakron00001
approved these changes
Aug 29, 2017
Contributor
|
pull request are not merged here. |
Author
|
Apparently, I don't have permissions to open a change on Gerrit. |
Contributor
|
After creation of your account you need to
1. Accept the contribute policy
2. Setup a username
3. Add your ssh key.
Le 5 septembre 2017 11:42:23 GMT+02:00, Chad Magendanz <notifications@github.com> a écrit :
…Apparently, I don't have permissions to open a change on Gerrit.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#174 (comment)
--
Envoyé de mon appareil LineageOS avec K-9 Mail. Veuillez excuser ma brièveté.
|
Author
|
Did all that, but now do I have to clone a new repository and recommit the change? Frankly, that would exceed the time I budgeted for this pull request. With AbduL missing in action, I seem to be the only one maintaining TWRP on Amlogic and Rockchip media boxes, but I guess any changes I make will stay local for now. |
Contributor
|
Is it possible to get TWRP working on PX5 radios? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BOARD_RECOVERY_BLDRMSG_OFFSET variable is still needed to set bootloader control block (BCB) offset for command-line arguments in the /misc partition on some configs, notably Rockchip devices. However, the code to convert it to the precompiler directive was removed. This restores it in an appropriate context.