Fix colormap generation and selection stability#595
Open
GoulagmanYt wants to merge 1 commit intoonlaj:masterfrom
Open
Fix colormap generation and selection stability#595GoulagmanYt wants to merge 1 commit intoonlaj:masterfrom
GoulagmanYt wants to merge 1 commit intoonlaj:masterfrom
Conversation
Fixed lazy colormap generation (no double-lock) and ensured all packaged gradients (agama/cmasher/cmocean/colorcet/hpluv/matplotlib) generate on demand with current LED gamma. Normalized handling of colormap names while keeping raw LCD values (e.g., “Rainbow ”) so both web UI and LCD can switch colormaps without crashes or stale lookups. On change (web or LCD), colormaps are now generated immediately; Rainbow/Velocity modes force-safe fallback if a LUT is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fixed lazy colormap generation (no double-lock) and ensured all packaged gradients (agama/cmasher/cmocean/colorcet/hpluv/matplotlib) generate on demand with current LED gamma.
-Normalized handling of colormap names while keeping raw LCD values (e.g., “Rainbow ”) so both web UI and LCD can switch colormaps without crashes or stale lookups.
-On change (web or LCD), colormaps are now generated immediately; Rainbow/Velocity modes force-safe fallback if a LUT is missing.