Skip to content

ci: add workflow to build for web#1377

Merged
staceybeard merged 8 commits intomainfrom
SB.github-actions-web-build
May 9, 2025
Merged

ci: add workflow to build for web#1377
staceybeard merged 8 commits intomainfrom
SB.github-actions-web-build

Conversation

@staceybeard
Copy link
Member

By submitting this merge request, I confirm the following:

  • The merge request title follows the conventional commits convention (see Backend project's README.md)
    • feat: minor app version will be incremented.
    • fix, deps, perf: patch app version will be incremented.
    • chore, ci, etc.: app version will not be incremented.
    • See semantic-release/commit-analyzer
      for complete set of rules.

Changes

Wrote a workflow to build and deploy the app for web via GitHub Actions. This is done automatically for dev, and can be run manually for other environments.

Dependencies

  • Listener: N/A

@staceybeard staceybeard self-assigned this May 8, 2025
@staceybeard staceybeard requested a review from mschoettle May 9, 2025 14:14
Copy link
Member

@mschoettle mschoettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In hindsight I think it would have been cleaner to avoid the environment in caps and just named the secret/var name with a lowercase env name.

@staceybeard
Copy link
Member Author

In hindsight I think it would have been cleaner to avoid the environment in caps and just named the secret/var name with a lowercase env name.

True, I'll think about changing that. We could make all the vars lowercase; I haven't seen the uppercase convention used much in GitHub guides.

@staceybeard staceybeard merged commit be64e3c into main May 9, 2025
2 checks passed
@staceybeard staceybeard deleted the SB.github-actions-web-build branch May 9, 2025 14:56
@staceybeard
Copy link
Member Author

True, I'll think about changing that. We could make all the vars lowercase; I haven't seen the uppercase convention used much in GitHub guides.

Update: the vars are case-insensitive, and actually automatically capitalize themselves when you create them. I'll remove the capitalization of the environment name since it isn't necessary to access the variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants