fix(i18n): migrate Korean to correct ISO code 'ko'#1306
fix(i18n): migrate Korean to correct ISO code 'ko'#1306yslpn wants to merge 5 commits intoopen-circle:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR migrates Korean language support from the incorrect ISO code 'kr' to the correct ISO 639-1 code 'ko' while maintaining backward compatibility.
- Adds proper 'ko' language code support with complete Korean translations
- Deprecates 'kr' with a JSDoc comment and keeps it as an alias for backward compatibility
- Updates build scripts, package exports, and documentation to include both codes
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/i18n/src/types.ts | Adds 'ko' to the Language union type |
| packages/i18n/src/kr.ts | Adds deprecation comment for 'kr' code |
| packages/i18n/src/ko.ts | Creates new Korean language file with 'ko' code |
| packages/i18n/scripts/build-npm.ts | Imports and includes 'ko' in build script |
| packages/i18n/scripts/build-jsr.ts | Imports and includes 'ko' in JSR build script |
| packages/i18n/package.json | Adds 'ko' export paths alongside existing 'kr' paths |
| packages/i18n/jsr.json | Adds 'ko' export mappings for JSR |
| packages/i18n/README.md | Updates documentation to show Korean as 'ko' instead of 'kr' |
| packages/i18n/CHANGELOG.md | Documents the migration and deprecation |
| packages/i18n/.gitignore | Adds 'ko' directory to gitignore |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thank you so much! I will try to make some time to merge it this or next week and publish a new version. |
commit: |
|
I haven't forgotten this PR and will probably merge it in 1 to 2 weeks. I am currently focused on Formisch a few other things. |
tats-u
left a comment
There was a problem hiding this comment.
You should deduplicate the data.
|
This PR is still on my list. Sorry for the delay. |
|
@yslpn is attempting to deploy a commit to the Valibot Team on Vercel. A member of the Team first needs to authorize it. |
|
I will merge it when working on Valibot v1.3 soon. |
|
Korean translations cannot be updated until this PR is merged. (I do not know if Korean translations have some defects) |
i18n: Migrate Korean to
ko, deprecatekrkokras a deprecated alias for backward compatibilitykoto build scripts (npm & JSR); preservekroutputskrwill be removed in a future majorMigration: prefer
@valibot/i18n/koinstead of@valibot/i18n/kr.Closes #1285