[Fix] livecodebench serialization and timeout errors#2204
Open
f14-bertolotti wants to merge 1 commit intoopen-compass:mainfrom
Open
[Fix] livecodebench serialization and timeout errors#2204f14-bertolotti wants to merge 1 commit intoopen-compass:mainfrom
f14-bertolotti wants to merge 1 commit intoopen-compass:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While evaluating with Livecodebench (LCB), I encountered two issues:
The existing timeout of 3 seconds frequently results in timeouts when using
ProcessPoolExecutor()with its default number of processes. To address this, I increased the timeout to 30 seconds.Using
ProcessPoolExecutor()with a local function causes a serialization error. This is resolved by moving the local function to the global namespace.Modifications
_temp_runto the global namespace.codeexecute_check_correctnessfrom 3 seconds to 30 seconds.Backward Compatibility
These changes are backward compatible. However, note that increasing the timeout may cause some tests to pass that would have previously failed due to exceeding the shorter timeout.
Checklist
Before PR:
After PR: