Skip to content

fix: remove file mode from forbidden flagd connection test#312

Merged
aepfli merged 1 commit intoopen-feature:mainfrom
open-feature-forking:fix/remove-file-mode-forbidden-connection-test
Nov 12, 2025
Merged

fix: remove file mode from forbidden flagd connection test#312
aepfli merged 1 commit intoopen-feature:mainfrom
open-feature-forking:fix/remove-file-mode-forbidden-connection-test

Conversation

@leakonvalinka
Copy link
Member

This PR

  • removes the file mode from the forbidden flagd connection test case

Related Issues

open-feature/go-sdk-contrib#756

@leakonvalinka leakonvalinka requested a review from a team as a code owner November 12, 2025 09:36
@gemini-code-assist
Copy link

Summary of Changes

Hello @leakonvalinka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines an existing test case within the Gherkin feature files by removing an extraneous tag. The modification specifically targets the 'Provider forbidden' scenario, ensuring that the test accurately reflects the intended behavior for handling forbidden flagd connections without being inadvertently constrained by file-based flag configurations. This adjustment contributes to a more precise and focused test suite.

Highlights

  • Test Case Refinement: The @file tag has been removed from the 'Provider forbidden' scenario within the gherkin/connection.feature file.
  • Issue Resolution: This change addresses an issue related to the forbidden flagd connection test, as detailed in issue #756.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the @file tag from the Provider forbidden scenario in gherkin/connection.feature. This aligns with the description, indicating that this test case is not related to file-based flagd connections, thus improving the accuracy of test categorization. The change is straightforward and addresses the intended fix without introducing any new issues.

Signed-off-by: lea konvalinka <lea.konvalinka@dynatrace.com>
@leakonvalinka leakonvalinka force-pushed the fix/remove-file-mode-forbidden-connection-test branch from feca0b6 to 4410fe5 Compare November 12, 2025 09:47
@leakonvalinka leakonvalinka changed the title fix: remove @file from forbidden flagd connection test fix: remove file mode from forbidden flagd connection test Nov 12, 2025
@aepfli aepfli merged commit 1759a94 into open-feature:main Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants