feat: Support multi-platform build#313
Conversation
Summary of ChangesHello @marcozabel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a TARGETARCH build argument to support multi-platform Docker builds, which is a great addition. My review focuses on improving the default behavior of this new argument to make it more robust and intuitive for developers on different architectures. Specifically, I'm suggesting a change to avoid hardcoding a default architecture, which will prevent building non-runnable images on non-amd64 platforms by default.
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
cede913 to
e692cc2
Compare
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
There was a problem hiding this comment.
Code Review
This pull request introduces support for multi-platform builds in the Dockerfile by using a TARGETARCH build argument. The approach is sound. My review includes one suggestion to make the build process more explicit and robust by providing a clear fallback for the target architecture when it's not specified.
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
This PR
Currently the flagd-testbed docker image cannot be run on arm64 machines, as go returns an error. To be able to build the docker image across multiple platforms a parameter was introduced to build the docker image for different architectures.
Follow-up Tasks
Automate the pipeline to build a docker image for both amd64 and arm64.
How to test
docker build --build-arg TARGETARCH=amd64 -t flagd-testbed:latest -f flagd/Dockerfile .
docker build --build-arg TARGETARCH=arm64 -t flagd-testbed:latest -f flagd/Dockerfile .