feat: [WIP] Add the open feature flipt client. Tests still required#179
feat: [WIP] Add the open feature flipt client. Tests still required#179atmask wants to merge 1 commit intoopen-feature:mainfrom
Conversation
Signed-off-by: atmask <benjaminajm@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 14 14
Lines 749 749
=======================================
Hits 707 707
Misses 42 42 ☔ View full report in Codecov by Sentry. |
markphelps
left a comment
markphelps
left a comment
There was a problem hiding this comment.
lgtm so far! one comment about adding a potential compatability note in the readme
thank you @atmask !!
|
|
||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
we may want to put a note in the README that this provider will only work on platforms that use Glibc as the C library. Also it will only work for the OS'es mentioned here because we are using FFI under the hood for the evaluation engine clientside: https://github.com/flipt-io/flipt-client-sdks?tab=readme-ov-file#ffi
|
|
||
| def get_metadata(self) -> Metadata: | ||
| return Metadata( | ||
| name='OpenFeature Flipt Client-Side Provider', |
There was a problem hiding this comment.
| name='OpenFeature Flipt Client-Side Provider', | |
| name='Flipt', |
I'd recommend keeping this as short as possible since it may be used in telemetry and logs.
| value=default_value, | ||
| reason=Reason.ERROR, | ||
| error_message=str(e), | ||
| error_code=None ## Explicitly set to None. No clear mapping atm from Flipt error to OpenFeature error codes |
There was a problem hiding this comment.
Please use the General error code if there isn't a more appropriate one.
3 participants
This PR
Background:
This PR adds a new provider to support flipt-client evaluation. This provider more flexibility to end users looking to consume from the Flipt and it allows OpenFeature to be used directly alongside Flipt Cloud which only supports the Client side sdk atm (self-hosted supports both client and server side sdks).
Implementation
Related Issues
#163
Follow-up Tasks