-
Notifications
You must be signed in to change notification settings - Fork 26
fix: replace project.scripts with poethepoet #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Summary of ChangesHello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the development workflow across several Python projects by adopting Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively replaces the custom Python scripts for running tasks with poethepoet, which simplifies the project configuration across multiple packages. The changes are consistent and well-executed. I've found one minor issue in the openfeature-provider-unleash package where the lint task and its ruff dependency were removed. I've added a suggestion to restore this functionality. Otherwise, the changes look great.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 25 25
Lines 1252 1252
=======================================
Hits 1196 1196
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR
poebecause Python 3.9 support was droppedRelated Issues
Relates to open-feature/python-sdk#563
Notes
Follow-up Tasks
poeversion and add the python version test matrix like in the sdk repo