Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Feb 2, 2026

This PR

  • I couldn't use the latest version of poe because Python 3.9 support was dropped

Related Issues

Relates to open-feature/python-sdk#563

Notes

Follow-up Tasks

  • after dropping Python 3.9 I'll properly upgrade to the latest poe version and add the python version test matrix like in the sdk repo

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel requested review from a team as code owners February 2, 2026 22:07
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the development workflow across several Python projects by adopting poethepoet for managing common development tasks. This change centralizes script definitions within pyproject.toml files, eliminating the need for separate custom script files and enhancing consistency and maintainability. This also prepares the projects for future Python version updates, allowing for an upgrade to the latest poe version once Python 3.9 support is fully dropped.

Highlights

  • Script Management Migration: The pull request migrates the project's script management from custom project.scripts definitions to poethepoet, centralizing task configurations within pyproject.toml files.
  • Removal of Custom Script Files: Corresponding custom Python script files (e.g., src/scripts/scripts.py) have been removed across various projects, as their functionality is now handled by poethepoet tasks.
  • Dependency Updates: Development dependencies have been updated to include poethepoet>=0.37.0, and specific projects received version bumps for mypy, uv_build, and types-requests, along with the removal of the ruff dependency in one instance.
Changelog
  • hooks/openfeature-hooks-opentelemetry/pyproject.toml
    • Added poethepoet>=0.37.0 to development dependencies.
    • Replaced the [project.scripts] section with [tool.poe.tasks], defining test, test-cov, cov-report, cov, and mypy tasks.
  • hooks/openfeature-hooks-opentelemetry/src/scripts/scripts.py
    • Removed the file, as its functionality is now handled by poethepoet tasks.
  • providers/openfeature-provider-env-var/pyproject.toml
    • Added poethepoet>=0.37.0 to development dependencies.
    • Removed the [tool.hatch.envs.hatch-test] section.
    • Replaced the [project.scripts] section with [tool.poe.tasks], defining test, test-cov, cov-report, cov, and mypy tasks.
  • providers/openfeature-provider-env-var/src/scripts/scripts.py
    • Removed the file, as its functionality is now handled by poethepoet tasks.
  • providers/openfeature-provider-flagd/pyproject.toml
    • Added poethepoet>=0.37.0 to development dependencies.
    • Replaced the [project.scripts] section with [tool.poe.tasks], defining test, test-cov, cov-report, cov, and mypy tasks.
  • providers/openfeature-provider-flagd/src/scripts/scripts.py
    • Removed the file, as its functionality is now handled by poethepoet tasks.
  • providers/openfeature-provider-flipt/pyproject.toml
    • Added poethepoet>=0.37.0 to development dependencies.
    • Replaced the [project.scripts] section with [tool.poe.tasks], defining test, test-cov, cov-report, cov, and mypy tasks.
  • providers/openfeature-provider-flipt/src/scripts/scripts.py
    • Removed the file, as its functionality is now handled by poethepoet tasks.
  • providers/openfeature-provider-ofrep/pyproject.toml
    • Added poethepoet>=0.37.0 to development dependencies.
    • Replaced the [project.scripts] section with [tool.poe.tasks], defining test, test-cov, cov-report, cov, and mypy tasks.
  • providers/openfeature-provider-ofrep/src/scripts/scripts.py
    • Removed the file, as its functionality is now handled by poethepoet tasks.
  • providers/openfeature-provider-unleash/pyproject.toml
    • Updated uv_build dependency from ~0.8.0 to ~0.9.0.
    • Updated mypy dependency from [faster-cache]>=1.17.0,<2.0.0 to >=1.18.0,<2.0.0.
    • Added poethepoet>=0.37.0 to development dependencies.
    • Updated types-requests dependency from >=2.31.0 to >=2.31.0,<3.0.0.
    • Removed ruff>=0.12.10 from development dependencies.
    • Replaced the [project.scripts] section with [tool.poe.tasks], defining test, test-cov, cov-report, cov, and mypy tasks.
  • providers/openfeature-provider-unleash/src/scripts/scripts.py
    • Removed the file, as its functionality is now handled by poethepoet tasks.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build.yml
Activity
  • No human activity detected in the pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively replaces the custom Python scripts for running tasks with poethepoet, which simplifies the project configuration across multiple packages. The changes are consistent and well-executed. I've found one minor issue in the openfeature-provider-unleash package where the lint task and its ruff dependency were removed. I've added a suggestion to restore this functionality. Otherwise, the changes look great.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.52%. Comparing base (b9c164a) to head (2e3807b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files          25       25           
  Lines        1252     1252           
=======================================
  Hits         1196     1196           
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants