sync: less shelf safe calls is more (fixes #11232) #11186
Conversation
Refactored `UploadToShelfService.kt` to remove redundant safe call operators (`?.`) on variables that are known to be non-nullable, such as Retrofit `Response` objects. Specifically: - Removed `?.` from `Response` objects returned by `ApiInterface` suspend functions (e.g., `res?.body()` -> `res.body()`, `response?.isSuccessful` -> `response.isSuccessful`). - Simplified boolean checks (e.g., `isSuccessful == true` -> `isSuccessful`). - Kept necessary safe calls where nullability is introduced (e.g., via `RetryUtils.retry` in `saveKeyIv`). This cleanup improves code readability and removes unnecessary null checks as per Kotlin's null safety guarantees for Retrofit's `Response<T>`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
dogi
changed the title
dogi
changed the title
2 participants
Removed unnecessary safe calls on non-nullable Retrofit Response objects in UploadToShelfService.kt. This includes
res.body(),response.isSuccessful, and simplifying boolean checks. Verified compilation and preserved necessary safe calls where appropriate.PR created automatically by Jules for task 1057705527000313514 started by @dogi