teams: less base safe calls is more (fixes #11233)#11187
Conversation
The `profileDbHandler` property is injected as a non-nullable `lateinit var` in the parent `BaseResourceFragment`. Therefore, using the safe call operator `?.` when accessing `userModel` in `BaseTeamFragment` is redundant. This commit replaces `profileDbHandler?.userModel` with `profileDbHandler.userModel` to clean up the code. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
dogi
changed the title
2 participants
Removed the safe call operator
?.fromprofileDbHandler?.userModelinBaseTeamFragment.kt.profileDbHandleris a non-nulllateinit var(UserSessionManager) inherited fromBaseResourceFragment, making the safe call unnecessary. This aligns with Kotlin best practices for non-nullable properties.PR created automatically by Jules for task 9333124544557771140 started by @dogi