Move formheading/hidehtml code to just before footer#41
Open
Limekiller wants to merge 1 commit intoopen-lms-open-source:masterfrom
Open
Move formheading/hidehtml code to just before footer#41Limekiller wants to merge 1 commit intoopen-lms-open-source:masterfrom
Limekiller wants to merge 1 commit intoopen-lms-open-source:masterfrom
Conversation
This fixes an issue where editor_tiny doesn't load on the post.php page because there is output (in this case, a style tag) above the <!DOCTYPE html> tag, which forces the page into quirks mode. TinyMCE doesn't load in quirks mode: https://stackoverflow.com/questions/68689918/tinymce-editor-is-not-loading-because-document-is-not-in-standards-mode-how-ca
Author
|
Hi all, Currently the advanced editor won't load on the post.php page of mod_hsuforum when using editor_tiny. To reproduce,
This issue is occurring because the post.php page prints output above the DOCTYPE tag. This is bad practice, and forces the page into quirks mode, which causes TinyMCE not to load. It didn't look like the code block that includes this styling is needed until the formheading conditional at the bottom of the file, so I moved it just above said conditional, allowing the editor to load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where editor_tiny doesn't load on the post.php page because there is output (in this case, a style tag) above the <!DOCTYPE html> tag, which forces the page into quirks mode. TinyMCE doesn't load in quirks mode: https://stackoverflow.com/questions/68689918/tinymce-editor-is-not-loading-because-document-is-not-in-standards-mode-how-ca