Open
Conversation
added 8 commits
July 31, 2023 17:58
demmerichs
force-pushed
the
laser_origins
branch
from
8cb3467 to
dcb8abd
Compare
demmerichs
force-pushed
the
laser_origins
branch
from
dcb8abd to
90bc193
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only adds 2 more commits on top of PR #1394 and introduces pointwise laser origins in the dataset loading and processing routine, enabled through the dataset config key
USE_ORIGINS=True.Laser origins can be interesting in order to track the laser rays shoot by a LiDAR scanner, in order to deduce empty space. E.g. MAELi makes use of this visibility concept.
I tested all changes and produced the following image from the loaded 'points' and 'origins' in the data_dict.
This images shows four consecutive point clouds loaded from the Waymo Open Dataset, the different shading of blue shows the different scans (dark newest to light oldest). The reddish colors show the position of the 5 LiDAR sensors and the outward traveling beams, corrected for the movement of the ego vehicle, hence different origins for each scan (yellow newest to red oldest). You can see how the Top LiDAR is 360deg while the lower LiDARs only are less than 180deg.
This demonstrates that the origin date is correctly corresponding to the point data.
I am happy to incorporate any feedback if this PR is deemed to be merged into the base repo.