Move probe initialization to auto#1906
Merged
MrAlias merged 2 commits intoopen-telemetry:mainfrom Mar 3, 2025
Merged
Conversation
MrAlias
force-pushed
the
mv-probe-list
branch
2 times, most recently
from
9fd1ed2 to
eee5d2b
Compare
Instead of initializing all probes within the manger, have Instrumentation handle the creation of all wanted probes. This cleans up unneeded context being passed to the NewManager call (i.e. globalImpl and Version()) and these values can be used where they are defined. This also is a first step in accepting probes as options to Instrumentation which is a goal of open-telemetry#1105.
Contributor
Author
Correct 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of initializing all probes within the manger, have Instrumentation handle the creation of all wanted probes.
This cleans up unneeded context being passed to the NewManager call (i.e. globalImpl and Version()) and these values can be used where they are defined.
This also is a first step in accepting probes as options to Instrumentation which is a goal of #1105.