Skip to content

Comments

Temporarily fix broken rolldice example#2890

Closed
OhJuhun wants to merge 1 commit intoopen-telemetry:mainfrom
OhJuhun:fix_broken_rolldice_temporarily
Closed

Temporarily fix broken rolldice example#2890
OhJuhun wants to merge 1 commit intoopen-telemetry:mainfrom
OhJuhun:fix_broken_rolldice_temporarily

Conversation

@OhJuhun
Copy link

@OhJuhun OhJuhun commented Oct 5, 2025

This PR provides a temporary fix for the rolldice example that is currently failing to build, as reported in issue #2889.

Problem
The rolldice example image fails to build with the following error:

go: go.opentelemetry.io/auto/sdk@v1.2.1 (replaced by ../../../sdk): reading /sdk/go.mod: open /sdk/go.mod: no such file or directory

Root Cause
This issue appears to be related to changes introduced in PR #2790, which modified the project structure or dependency management in a way that affects the local module replacement.

Temporary Solution
This fix removes the problematic replace directive from examples/rolldice/user/go.mod and allows the dependency to be resolved normally from the published version.

Why This is Temporary
This is a temporary workaround because:

  1. We need to analyze the changes made in PR Release v0.23.0/v1.2.0 #2790 more thoroughly to understand the underlying structural changes
  2. Similar issues may occur again if directory structure or module paths are modified in the future without proper consideration of the examples
  3. A more robust, permanent solution is needed to prevent this type of breakage from recurring

Next Steps

  • Investigate the exact changes in PR Release v0.23.0/v1.2.0 #2790 that caused this issue
  • Develop a more permanent solution that accounts for project structure changes
  • Add safeguards to prevent similar issues in future structural modifications

Fixes #2889

@OhJuhun OhJuhun requested a review from a team as a code owner October 5, 2025 08:04
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local version should be used. The replace statement needs to persist.

If there is a docker image missing a copy of the local module that docker file needs to be updated to have a copy of this module added.

@MrAlias
Copy link
Contributor

MrAlias commented Oct 6, 2025

Superseded by #2894

@MrAlias MrAlias closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

examples/rolldice/user fails to build

2 participants