otlp: wrap the Cause error when context is canceled#7811
Open
bboreham wants to merge 1 commit intoopen-telemetry:mainfrom
Open
otlp: wrap the Cause error when context is canceled#7811bboreham wants to merge 1 commit intoopen-telemetry:mainfrom
bboreham wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…ailable This brings things into alignment with the `wait` function. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7811 +/- ##
=====================================
Coverage 86.1% 86.1%
=====================================
Files 302 302
Lines 22046 22046
=====================================
Hits 18991 18991
- Misses 2674 2675 +1
+ Partials 381 380 -1
🚀 New features to boost your workflow:
|
pellared
reviewed
Jan 20, 2026
| // Check if context is canceled before attempting to wait and retry. | ||
| if ctx.Err() != nil { | ||
| return fmt.Errorf("%w: %w", ctx.Err(), err) | ||
| return fmt.Errorf("%w: %w", context.Cause(ctx), err) |
Member
There was a problem hiding this comment.
Can we add a new test case in TestWait that would cover the change?
dashpole
approved these changes
Jan 21, 2026
MrAlias
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings things into alignment with the
waitfunction.I don't believe this is a "notable" change, so doesn't need a CHANGELOG entry.