-
Notifications
You must be signed in to change notification settings - Fork 1.3k
TracerProvider ForceFlush() Error Fix #7856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TracerProvider ForceFlush() Error Fix #7856
Conversation
|
|
dashpole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Can you add a test?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7856 +/- ##
=======================================
- Coverage 81.6% 81.5% -0.1%
=======================================
Files 304 304
Lines 23285 23286 +1
=======================================
- Hits 19012 18993 -19
+ Misses 3868 3866 -2
- Partials 405 427 +22
🚀 New features to boost your workflow:
|
|
Sorry for pinging while checks are failing - working on it. |
…y-go into trace-force-flush-errors
…opentelemetry-go into trace-force-flush-errors
Previously upon a SpanProcessor's ForceFlush returning an error, it would return that error and not attempt to flush subsequent SpanProcessors. Now when an error is encountered, it will Join the new error with the existing errors and continue iterating through the SpanProcessors and return the consolidated error at the end of iteration. This is in line with the workflow found in LoggerProvider's ForceFlush.