Skip to content

Conversation

@sawamurataxman
Copy link

Previously upon a SpanProcessor's ForceFlush returning an error, it would return that error and not attempt to flush subsequent SpanProcessors. Now when an error is encountered, it will Join the new error with the existing errors and continue iterating through the SpanProcessors and return the consolidated error at the end of iteration. This is in line with the workflow found in LoggerProvider's ForceFlush.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 31, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sawamurataxman / name: sawamurataxman (d2b7dc3)

@sawamurataxman sawamurataxman marked this pull request as ready for review January 31, 2026 17:24
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can you add a test?

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.5%. Comparing base (490fd7f) to head (d2b7dc3).

Files with missing lines Patch % Lines
sdk/trace/provider.go 33.3% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7856     +/-   ##
=======================================
- Coverage   81.6%   81.5%   -0.1%     
=======================================
  Files        304     304             
  Lines      23285   23286      +1     
=======================================
- Hits       19012   18993     -19     
+ Misses      3868    3866      -2     
- Partials     405     427     +22     
Files with missing lines Coverage Δ
sdk/trace/provider.go 76.3% <33.3%> (-9.5%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sawamurataxman
Copy link
Author

Sorry for pinging while checks are failing - working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants