fix(otlp-exporter-base): handle 64KiB limit for browser transports #6358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Browser environments have a 64KiB limit for
sendBeaconandfetchwithkeepalive: true. When the request exceeds this limit:sendBeaconreturnsfalsefetchwithkeepalivemay fail silently in some browsers (Firefox) or throw an error (Chrome)This causes telemetry data loss for larger batches without any fallback mechanism.
Related #3489
Short description of the changes
keepalivefor body size >= 60KiB (leaving room for headers)truein existing testsThe size-based approach for
fetchtransport is not a perfect solution since we cannot know the exact final request size (headers, encoding overhead, etc.). However, this change:keepalivebeing unconditionally set totruein browser environmentsFor
sendBeacon, the FailoverTransport provides a more robust solution sincesendBeaconexplicitly returnsfalsewhen the request cannot be queued.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: