refactor: parametrize tests#3256
Draft
chickenbreeder wants to merge 1 commit intoopen-telemetry:mainfrom
Draft
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
=======================================
- Coverage 80.8% 80.7% -0.1%
=======================================
Files 129 129
Lines 23203 23167 -36
=======================================
- Hits 18750 18714 -36
Misses 4453 4453 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I asked Claude to see if there are many others here we could pick up. Not sure how useful this is, but it's probably worth trying to pick out other instances of this pattern we can clean up!
|
Member
|
@chickenbreeder let me know when you are ready with this! |
Member
|
Hey @chickenbreeder , did you want to do more of these, or should we review it as it is? |
Author
|
Hey @scottgerring. Sorry, I did not get around to do any further work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1552
Changes
rstestversion to no longer depend on async-std by default (See: fix: do not depend by default onasync-stdla10736/rstest#311); this issue only occurred in the context ofMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes