fix(proto): Permissive integers in protobuf JSON parsing#3329
Open
marc-pydantic wants to merge 6 commits intoopen-telemetry:mainfrom
Open
fix(proto): Permissive integers in protobuf JSON parsing#3329marc-pydantic wants to merge 6 commits intoopen-telemetry:mainfrom
marc-pydantic wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3329 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 128 128
Lines 23641 23641
=====================================
+ Hits 19228 19232 +4
+ Misses 4413 4409 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8e81665 to
e7d6cdc
Compare
Author
|
Had some issue with the CLA system, but these are resolved now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3328
Changes
Ensure that we accept both
u64andStringas inputs for large numbers, as the protobuf spec dictates (see #3328).Note: This deviates in pattern slightly from established code, using a visitor for
IntOrString-- I hope this is okay, but there's potential to unify here.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes(Technically it is an API change, since more values are now accepted?)