Skip to content

Some more small tests fixes/enhancements#661

Merged
meaksh merged 6 commits intoopenSUSE/release/3006.0from
openSUSE/fix/3006.0-more-fixes-for-salt-shaker
Jul 8, 2024
Merged

Some more small tests fixes/enhancements#661
meaksh merged 6 commits intoopenSUSE/release/3006.0from
openSUSE/fix/3006.0-more-fixes-for-salt-shaker

Conversation

@meaksh
Copy link
Member

@meaksh meaksh commented Jul 5, 2024

What does this PR do?

This PR just add few more fixes to detected issues by Salt Shaker.

Related to: https://github.com/SUSE/spacewalk/issues/23286
Upstream PR: saltstack/salt#66695

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@meaksh meaksh merged commit e4333e2 into openSUSE/release/3006.0 Jul 8, 2024
@meaksh meaksh deleted the openSUSE/fix/3006.0-more-fixes-for-salt-shaker branch July 8, 2024 15:58
meaksh added a commit that referenced this pull request Oct 29, 2024
* test_system: prevent errors when systemd-timesyncd service is masked

* test_custom_module: disable tests when running on Salt Bundle

* Fix debian 12 package tests

* pam: use sys.executable in case /usr/bin/python3 does not exist

* pam: add unit test to ensure sys.executable is used

* Use proper method to calculate the path to Python interpreter

---------

Co-authored-by: Megan Wilhite <mwilhite@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants