Merged
Conversation
…ctive and fix minor formatting issues
…g and conditional rendering for action buttons
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves frontend UX around live streaming and backend connectivity configuration, with additional UI polish and formatting consistency updates.
Changes:
- Adds a “stream inactive” placeholder UI in the live view and refactors the live view container styling.
- Redesigns the connection settings workflow to prefer URL-based smart defaults and hides advanced configuration behind an accordion.
- Small UX tweaks (e.g., disabling snap/record inputs while live view is inactive) and formatting/style consistency updates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
frontend/src/axon/LiveViewControlWrapper.js |
Adds inactive-stream placeholder UI and refactors the viewer container to a styled MUI Box. |
frontend/src/components/ConnectionSettings.jsx |
Reworks connection settings initialization and presents advanced overrides in an accordion. |
frontend/src/components/StreamControls.js |
Disables snap/record controls unless the live view stream is active. |
frontend/src/constants/appRegistry.js |
Updates app registry metadata (notably app IDs/essential flags) and minor formatting changes. |
Comments suppressed due to low confidence (1)
frontend/src/components/ConnectionSettings.jsx:150
- The auto-test branch returns a cleanup that only clears the timeout (
return () => clearTimeout(timer);) and does not dispatch the "pausePeriodicTests" resume event. If the component unmounts before the effect re-runs (aftersetHasAutoTested(true)), periodic checks can remain paused infrontend/src/middleware/WebSocketHandler.js. Consider using a single cleanup function that always resumes periodic tests, and additionally clears any pending timeout when present.
);
}, 1500); // Delay to allow component to settle
return () => clearTimeout(timer);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to both the live view UI and the connection settings workflow, focusing on better user experience and code maintainability. The most significant changes include enhancements to placeholder handling in the live view, a redesigned connection settings form with smarter defaults and clearer separation between automatic and advanced configuration, and general UI/UX refinements.
Live View UI Improvements
frontend/src/axon/LiveViewControlWrapper.js, frontend/src/axon/LiveViewControlWrapper.jsR305-R338)divto aBoxwith improved styling: minimum height, background color, border, and rounded corners to prevent collapse and enhance visual consistency. (frontend/src/axon/LiveViewControlWrapper.js, [1] [2]Connection Settings UX and Logic
frontend/src/components/ConnectionSettings.jsx, [1] [2] [3]frontend/src/components/ConnectionSettings.jsx, [1] [2] [3]Code Quality and Consistency
frontend/src/axon/LiveViewControlWrapper.js, [1] [2] [3] [4] [5];frontend/src/components/ConnectionSettings.jsx, [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16];frontend/src/components/StreamControls.js, [17] [18]These changes collectively make the frontend more robust, intuitive, and maintainable.