Open
Conversation
Author
|
Hi @peterdudfield |
| @@ -510,7 +510,7 @@ def scan_parameter_values(self, p: Parameter) -> ResultE[ParameterScanResult]: | |||
| ParameterScanResult( | |||
Contributor
There was a problem hiding this comment.
have you changed the object ParameterScanResult anywhere? I suspect you will need to if you want this change.
Aslo have you run pytest to check these changes?
Author
There was a problem hiding this comment.
Yes @peterdudfield , I updated the ParameterScanResult object completely.
- Field renamed:
has_nulls: bool→has_nans: boolwith updated documentation scan.has_nulls→scan.has_nansandhas_nulls=False→has_nans=False- Tests pass: All 4 tests in test_tensorstore.py run successfully.
Please let me know if any changes are required..?
Thank you!
peterdudfield
approved these changes
Sep 3, 2025
Contributor
peterdudfield
left a comment
peterdudfield
left a comment
There was a problem hiding this comment.
Thanks for this. I just need to find a way to make sure CI runs for external collobrators. Then we can merge
Author
|
Sure @peterdudfield |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285