-
-
Notifications
You must be signed in to change notification settings - Fork 15
Add MTG Highres config #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -152,7 +152,7 @@ def _serialize(d: dict[str, Any]) -> dict[str, Any]: | |
| if "time" not in da.dims: | ||
| time = pd.to_datetime(rounded_time) | ||
| da = da.assign_coords({"time": time}).expand_dims("time") | ||
|
|
||
| da.attrs.pop("_FillValue", None) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. im not sure this is right? I saw some errors like this with the upgrade from zarr2 to zarr3. What error do you get if you dont include this?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this isn't here, it gives an error of Removing the FillValue here fixes that and allows for the dataarrays to be added to the Icechunk store successfully
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a funny, does that happen for you on the other satellites? What python version you running? What zarr, xarray and icechunk version you running?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Its with Zarr 3.1.1, Xarray 2025.7.1, icechunk 1.1.1 It doesn't with the other ones, but the MTG format is quite a bit different than the MSG ones. In #44, this also does show up for other geostationary satellites as well. |
||
| # Increase clarity of coordinates, including coordinate dimension names and attributes | ||
| da = da.rename({"x": "x_geostationary", "y": "y_geostationary"}) | ||
| for name in ["x_geostationary", "y_geostationary"]: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.