Clean up implicit historic logic in national forecast endpoint#525
Open
iivanhaj wants to merge 3 commits intoopenclimatefix:mainfrom
Open
Clean up implicit historic logic in national forecast endpoint#525iivanhaj wants to merge 3 commits intoopenclimatefix:mainfrom
iivanhaj wants to merge 3 commits intoopenclimatefix:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #470
This removes the hidden historic-mode switch in the national /forecast endpoint and makes the behavior explicit and consistent by always using the latest-forecast path.
How Has This Been Tested?
Ran
python -m py_compile nowcasting_api/national.pyto verify there are no syntax errors.Manual code review to confirm the endpoint logic is now deterministic and does not depend on implicit historic mode.
Yes
Checklist: