Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 7, 2026

The shellcheck workflow installs PHP and cs2pr but uses staabm/annotate-pull-request-from-checkstyle-action to process checkstyle output instead. The PHP setup is vestigial.

Changes

  • Removed PHP 8.4 setup step and cs2pr tool installation from .github/workflows/shellcheck.yml

The workflow flow remains unchanged:

# shellcheck outputs checkstyle format
shellcheck --format=checkstyle $files | tee checkstyle-shellcheck.xml

# staabm action processes it (not cs2pr)
- uses: staabm/annotate-pull-request-from-checkstyle-action@v1
  with:
    files: checkstyle-shellcheck.xml
Original prompt

This section details on the original issue you should resolve

<issue_title>ci(shellcheck): Remove unnecessary PHP setup</issue_title>
<issue_description>## Summary

The shellcheck.yml workflow installs PHP with the cs2pr tool, but cs2pr is never actually used. The workflow:

  1. Runs shellcheck with --format=checkstyle output
  2. Uses staabm/annotate-pull-request-from-checkstyle-action@v1 to annotate PRs

The PHP setup step appears to be vestigial and could be removed to simplify the workflow and reduce CI time.

Current code

- name: Setup PHP with cs2pr
  uses: shivammathur/setup-php@v2
  with:
    php-version: '8.4'
    # cs2pr enables us to convert checkstyle output to github annotations
    tools: cs2pr

Suggested change

Remove the PHP setup step entirely, as cs2pr is not called anywhere in the workflow.

Additional context

Discovered while consolidating setup-php usage across CI workflows.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: kojiromike <1566303+kojiromike@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove unnecessary PHP setup from shellcheck workflow ci(shellcheck): remove unused PHP setup and cs2pr tool Feb 7, 2026
Copilot AI requested a review from kojiromike February 7, 2026 04:43
@kojiromike kojiromike marked this pull request as ready for review February 7, 2026 04:45
@kojiromike kojiromike added DevOps For development and technical operation of OpenEMR and its modules. github-actions labels Feb 7, 2026
@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.24%. Comparing base (5da24e5) to head (5cc94c9).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10625      +/-   ##
============================================
- Coverage     16.27%   16.24%   -0.04%     
  Complexity    80367    80367              
============================================
  Files          3664     3664              
  Lines        384479   384479              
============================================
- Hits          62579    62443     -136     
- Misses       321900   322036     +136     
Flag Coverage Δ
apache 13.89% <ø> (-0.04%) ⬇️
api 2.47% <ø> (+<0.01%) ⬆️
common 0.54% <ø> (+<0.01%) ⬆️
controllers 1.90% <ø> (+<0.01%) ⬆️
e2e 10.55% <ø> (-0.04%) ⬇️
email 0.52% <ø> (+<0.01%) ⬆️
fixtures 0.49% <ø> (+<0.01%) ⬆️
http 1.20% <ø> (ø)
inferno 1.20% <ø> (ø)
isolated 2.58% <ø> (ø)
mariadb11.4 ?
mariadb11.8 13.89% <ø> (?)
php8.2 16.20% <ø> (+13.62%) ⬆️
php8.3 2.58% <ø> (ø)
php8.4 3.66% <ø> (-12.61%) ⬇️
php8.5 2.58% <ø> (ø)
php8.6 2.58% <ø> (ø)
services 3.00% <ø> (-0.01%) ⬇️
unit 1.54% <ø> (+<0.01%) ⬆️
validators 0.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kojiromike kojiromike merged commit fc33e0f into master Feb 7, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DevOps For development and technical operation of OpenEMR and its modules. github-actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(shellcheck): Remove unnecessary PHP setup

3 participants