Use yt-dlp from Alpine repository instead from Arkade#16
Use yt-dlp from Alpine repository instead from Arkade#16ema-pe wants to merge 1 commit intoopenfaas:masterfrom
Conversation
|
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
This is required because the yt-dlp package from Alpine's repository is provided as a static binary, specifically designed to run on Alpine containers. Signed-off-by: Emanuele Petriglia <inbox@emanuelepetriglia.com>
ema-pe
force-pushed
the
fix-youtube-dl
branch
from
0c40a60 to
f35250b
Compare
|
If you want to test here there is a compiled image ready to use: https://github.com/ema-pe/store-functions/pkgs/container/openfaas-youtube-dl |
| rm -rf /tmp/* && rm -rf /usr/local/bin/arkade | ||
| # Download yt-dlp, an updated alternative to youtube-dl, from Alpine repository | ||
| # since it is packaged as static binary compatible with Alpine. | ||
| RUN apk add --no-cache ca-certificates yt-dlp |
There was a problem hiding this comment.
I read that yt-dlp required Node or Bun etc now going forward to solve captchas.
Thoughts?
Did you want to also update the alpine version.
There was a problem hiding this comment.
From what I can see in the Alpine repository, the yt-dlp package depends on the yt-dlp-ejs package, which pulls in a JavaScript runtime. There is also a related issue discussing this. At the moment, it seems a JS runtime is not actually downloaded, but I think that in the future the Alpine maintainer will enable it through the yt-dlp-ejs package.
There was a problem hiding this comment.
Did you want to also update the alpine version.
I didnit update it, as you may prefer to do it manually together with the other functions in a single commit.
2 participants
This pull request fixes #14 by downloading the yt-dlp package from Alpine's repository, since it is provided as a static binary that can run on Alpine containers. The version from Arkade is more suitable for "normal" deployments where a full system is present, including glibc.