Open
Conversation
This fixes Go template to set app group properly. Fixes [openfaas#41](openfaas#41). Before used to add GEO data for user, after the change adds group to user Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
Member
|
Please ping Kiril. I think we had some issues when using the proper user group. |
Member
Member
|
I am pretty sure we can't merge this change since it caused permissions errors with buildkit in OpenFaaS Cloud. Pinging: @kvuchkov |
Member
|
Derek add label: blocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Go template to set app group properly.
Before used to add GEO data for user, after the change adds group to user
Signed-off-by: Ivana Yovcheva (VMware) iyovcheva@vmware.com
Description
Motivation and Context
Which issue(s) this PR fixes
Fixes #41
How Has This Been Tested?
Manually tested with
docker run -ti <image> shand by building function template.Types of changes
Checklist:
git commit -s