Do a better job at ending connection when switching from normal<->service position source#7046
Do a better job at ending connection when switching from normal<->service position source#7046
Conversation
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures🪟 Windows buildsDownload a Windows build of this PR for testing. 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. |
f276e2b to
d797fbf
Compare
mohsenD98
left a comment
There was a problem hiding this comment.
All looks good overall! Just one point caught my attention:
28fe317 to
784659a
Compare
|
@nirvn Let me know when it makes sense to test the next apk and which one I should install. Thanks |
|
@bladnor , could you try this PR? My GNSS device died on me yesterday :( |
|
@nirvn I had time to make a short test.
PS: Since we are an official dealer of Emlid gnss we could replace your broken device with the brand new RX2 (https://emlid.com/de/reachrx2/) . May be @mbernasocchi can invest in an additional gnss for testing. We have RX2 on stock and I could send you one on Monday. Let me know if you need a quote :-). |
|
@bladnor , is the project you are using to test available on QFieldCloud? Could I get that cloud project name? |
0cf499a to
7dcb003
Compare
|
Yes, it is. You can take the same you used to analyze the problem during your team event last year. You are still a collaborator on the project. The name ist go...ew/o...n-test/ |
7dcb003 to
ea02bfd
Compare
8192949 to
dd46184
Compare
dd46184 to
f3c31dc
Compare
|
@bladnor , this PR can be tested again, it includes the other PR that was meant to fix the remaining freezes. Crossing fingers. |
Summary: Tracking could still be improved, but the app never crashes, and it looks like no data is lost during UI freezes. I would say that this is a version that we can use without getting frustrated people. Cool, good job. PS: I encountered two other minor issues, which I described in new tickets: PPS: Do you want me to hire as test engineer ;-) . |
Trying to address #7039