Skip to content

Do a better job at ending connection when switching from normal<->service position source#7046

Merged
nirvn merged 7 commits intomasterfrom
bluetooth_solidify
Feb 25, 2026
Merged

Do a better job at ending connection when switching from normal<->service position source#7046
nirvn merged 7 commits intomasterfrom
bluetooth_solidify

Conversation

@nirvn
Copy link
Member

@nirvn nirvn commented Feb 10, 2026

Trying to address #7039

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Feb 10, 2026

🍎 MacOS DMG universal builds

Download a MacOS DMG universal build of this PR for testing.
(Built from commit f3c31dc)

📱 Android builds

Download an Android arm64 build of this PR for testing.
(Built from commit f3c31dc)

Other Android architectures

🪟 Windows builds

Download a Windows build of this PR for testing.
(Built from commit f3c31dc)

🐧 Linux AppImage builds

Download a Linux AppImage build of this PR for testing.
(Built from commit f3c31dc)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@nirvn nirvn force-pushed the bluetooth_solidify branch 3 times, most recently from f276e2b to d797fbf Compare February 11, 2026 03:15
Copy link
Collaborator

@mohsenD98 mohsenD98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good overall! Just one point caught my attention:

@nirvn nirvn force-pushed the bluetooth_solidify branch 2 times, most recently from 28fe317 to 784659a Compare February 13, 2026 01:40
@bladnor
Copy link

bladnor commented Feb 14, 2026

@nirvn Let me know when it makes sense to test the next apk and which one I should install. Thanks

@nirvn
Copy link
Member Author

nirvn commented Feb 14, 2026

@bladnor , could you try this PR? My GNSS device died on me yesterday :(

@bladnor
Copy link

bladnor commented Feb 14, 2026

@nirvn I had time to make a short test.

  1. In tracking mode the regular +, -, red cancel and green accept buttons are shown but not from the beginning of tracking. I don' understand what they should do during tracking.
  2. The observed disconnect did not happen at all. Great.
  3. In line tracking the UI stays responsive but freezes about every 10 seconds or so. Must be your 10-second limit. The UI freeze is quite long. About 3 to 5 seconds. Then the UI becomes responsive again for some time, which is great, but then freezes again.
    Summary:
    It looks like you are on the right track. But UI should not freeze at all. Can't you do the saving on a background task to keep the UI thread responsive?

PS: Since we are an official dealer of Emlid gnss we could replace your broken device with the brand new RX2 (https://emlid.com/de/reachrx2/) . May be @mbernasocchi can invest in an additional gnss for testing. We have RX2 on stock and I could send you one on Monday. Let me know if you need a quote :-).

@nirvn
Copy link
Member Author

nirvn commented Feb 15, 2026

@bladnor , is the project you are using to test available on QFieldCloud? Could I get that cloud project name?

@nirvn nirvn force-pushed the bluetooth_solidify branch from 0cf499a to 7dcb003 Compare February 15, 2026 09:59
@bladnor
Copy link

bladnor commented Feb 15, 2026

Yes, it is. You can take the same you used to analyze the problem during your team event last year. You are still a collaborator on the project. The name ist go...ew/o...n-test/

@nirvn
Copy link
Member Author

nirvn commented Feb 17, 2026

@bladnor , fantastic. I believe this new PR (#7061) takes care of the remaining UI freeze every 10 seconds.

@nirvn nirvn force-pushed the bluetooth_solidify branch from 7dcb003 to ea02bfd Compare February 19, 2026 02:24
@nirvn nirvn force-pushed the bluetooth_solidify branch 2 times, most recently from 8192949 to dd46184 Compare February 21, 2026 11:33
@nirvn nirvn force-pushed the bluetooth_solidify branch from dd46184 to f3c31dc Compare February 21, 2026 11:48
@nirvn
Copy link
Member Author

nirvn commented Feb 22, 2026

@bladnor , this PR can be tested again, it includes the other PR that was meant to fix the remaining freezes. Crossing fingers.

@bladnor
Copy link

bladnor commented Feb 22, 2026

@nirvn,

  1. The process for adding a Bluetooth GNSS now works better and it feels more stable. The drop-down menu with the list of GNSS to be added no longer displays a white line. Great.

  2. Line tracking: The longer the tracking lasts, the more frequently the user interface freezes, lasting up to approx. 5 seconds until the user interface responds again. Compared to the last version, the freezing feels to occur less often and mostly for a shorter time.

  3. Point tracking: Works well.

  4. Polygon tracking: Works well.

  5. Changing the zoom level during tracking: The user interface takes a few seconds to update the screen to the new zoom level. Works good enough for me.

Summary: Tracking could still be improved, but the app never crashes, and it looks like no data is lost during UI freezes. I would say that this is a version that we can use without getting frustrated people. Cool, good job.

PS: I encountered two other minor issues, which I described in new tickets:
#7073
#7074

PPS: Do you want me to hire as test engineer ;-) .

@nirvn nirvn merged commit 2cd9e1f into master Feb 25, 2026
26 checks passed
@nirvn nirvn deleted the bluetooth_solidify branch February 25, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants