Allow for the attribute form model to manually set a given feature's attribute values and geometry#7067
Merged
Allow for the attribute form model to manually set a given feature's attribute values and geometry#7067
Conversation
Collaborator
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures🪟 Windows buildsDownload a Windows build of this PR for testing. 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. |
kaustuvpokharel
approved these changes
Feb 22, 2026
Comment on lines
+1130
to
+1131
| if ( !mLayer || !mFeatureModel ) | ||
| return false; |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ( !mLayer || !mFeatureModel ) | |
| return false; | |
| if ( !mLayer || !mFeatureModel ) | |
| { | |
| return false; | |
| } |
Member
Author
There was a problem hiding this comment.
We can do these later when we upgrade the whole .cpp -- something on my radar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unlocks a nice set of invokable functions that ultimately allows for QML editor widget to become not only read-only but with capability to edit feature attributes and geometry.
In turn, it allows for coming up with nice custom widgets. Here's an example (the nice icon horizontal list at the top):
Screencast.From.2026-02-20.18-11-53.mp4