Conversation
…to `s3.S3Storage`
There was a problem hiding this comment.
LGTM 👍
The changelog also mentions that the install extra is now s3 (so that would be django-storages[s3]). However, I noticed that we're not even using that extra, we just depend on django-storages==1.14.6.
Is there a particular reason for that? It's not a big deal, since that extra does nothing more than pull inboto3>=1.4.4, which we also pull in directly, but it's still usually good practice to declare dependencies like that.
Just something I noticed though, totally fine to merge without that extra IMHO.
|
Thanks @lukasgraf !
@suricactus do you have an idea ? |
|
No idea, do the best it can be. |
|
Okey thanks, then trusting @lukasgraf's approval, |
Since v1.14 of
django-storageintroduces a dependency import change :becomes