Skip to content

chore: update django storage import from s3boto3.S3Boto3Storage to s3.S3Storage#1475

Merged
gounux merged 1 commit intomasterfrom
QF-7331-change-django-s3-storage-namespace
Feb 11, 2026
Merged

chore: update django storage import from s3boto3.S3Boto3Storage to s3.S3Storage#1475
gounux merged 1 commit intomasterfrom
QF-7331-change-django-s3-storage-namespace

Conversation

@gounux
Copy link
Member

@gounux gounux commented Feb 10, 2026

Since v1.14 of django-storage introduces a dependency import change :

from storages.backends.s3boto3 import S3Boto3Storage

becomes

from storages.backends.s3 import S3Storage

@duke-nyuki
Copy link
Collaborator

Copy link
Contributor

@lukasgraf lukasgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The changelog also mentions that the install extra is now s3 (so that would be django-storages[s3]). However, I noticed that we're not even using that extra, we just depend on django-storages==1.14.6.

Is there a particular reason for that? It's not a big deal, since that extra does nothing more than pull inboto3>=1.4.4, which we also pull in directly, but it's still usually good practice to declare dependencies like that.

Just something I noticed though, totally fine to merge without that extra IMHO.

@gounux
Copy link
Member Author

gounux commented Feb 11, 2026

Thanks @lukasgraf !

Is there a particular reason for that? It's not a big deal, since that extra does nothing more than pull inboto3>=1.4.4, which we also pull in directly, but it's still usually good practice to declare dependencies like that.

@suricactus do you have an idea ?

@suricactus
Copy link
Collaborator

No idea, do the best it can be.

@gounux
Copy link
Member Author

gounux commented Feb 11, 2026

Okey thanks, then trusting @lukasgraf's approval,

@gounux gounux merged commit dff5266 into master Feb 11, 2026
21 checks passed
@gounux gounux deleted the QF-7331-change-django-s3-storage-namespace branch February 11, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants