Skip to content

Comments

chore: drop support of legacy storage#1478

Open
gounux wants to merge 22 commits intomasterfrom
QF-4963-drop-support-of-legacy-storage-code
Open

chore: drop support of legacy storage#1478
gounux wants to merge 22 commits intomasterfrom
QF-4963-drop-support-of-legacy-storage-code

Conversation

@gounux
Copy link
Member

@gounux gounux commented Feb 11, 2026

The title says it : drop support of the historic and legacy QFieldCloud storage.

After this potential long-life PR gets merged, QFieldCloud will not support any S3 storage flagged as "QFC_IS_LEGACY": true in the .env's STORAGES var anymore.

So far the work has consisted of grepping for any QF-4963 / legacy occurrences.
Some of them are still there, and at the moment this is a WIP / draft.

Note : the pre-commit tools were quite useful regarding deletions that were sometimes too abrupt.

@duke-nyuki
Copy link
Collaborator

Comment on lines 621 to 624
if not context.get("project__the_qgis_file_name"):
context["project__the_qgis_file_name"] = get_qgis_project_file(
context["project__id"]
)
Copy link
Member Author

@gounux gounux Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it makes sense to keep it like this, i.e. if project__the_qgis_file_name might be empty on default storage only,

@gounux gounux marked this pull request as ready for review February 17, 2026 16:30
@gounux
Copy link
Member Author

gounux commented Feb 17, 2026

CI tests are green, but a lot of utils functions have been kept back, maybe the code could be made more lighter by having a logic look at why those functions commented with "TODO Delete with QF-4963" are still in use. Keeping the do not merge tag though,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants