fix: enable signup using invitations when signup closed#1480
Merged
Conversation
When `AccountAdapterSignUpClosed` is set, Invitations don't work. They can be sent out but when the invited user is trying to access the link, they can't signup since it's closed - Added a new validation to `AccountAdapterSignUpClosed` to allow signups on valid invitations - Added `get_user_signed_up_signal` to `AccountAdapter` so invitations works properly - Changed `INVITATIONS_ACCEPT_INVITE_AFTER_SIGNUP` setting to `True` to avoid invitation edge cases
Collaborator
gounux
reviewed
Feb 11, 2026
toebivankenoebi
approved these changes
Feb 11, 2026
Contributor
toebivankenoebi
left a comment
toebivankenoebi
left a comment
There was a problem hiding this comment.
Looks good to me.
lukasgraf
approved these changes
Feb 11, 2026
Contributor
lukasgraf
left a comment
lukasgraf
left a comment
There was a problem hiding this comment.
LGTM! 👍
I would however test signup via SSO again, after this is shipped. First login via SSO is another method of account creation that we have, which should also work when signup is otherwise closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
AccountAdapterSignUpClosedis set, Invitations don't work. They can be sent out but when the invited user is trying to access the link, they can't signup since it's closedAccountAdapterSignUpClosedto allow signups on valid invitationsget_user_signed_up_signaltoAccountAdapterso invitations works properlyINVITATIONS_ACCEPT_INVITE_AFTER_SIGNUPsetting toTrueto avoid invitation edge cases