[pushsafer] Add latest parameter answeroptions and answerforce

[appzer]

• [Pushsafer] add latest parameter answeroptions and answerforce
  ao = https://www.pushsafer.com/en/pushapi_ext#API-AO
  af = https://www.pushsafer.com/en/pushapi_ext#API-AF

[lsiepel]

Thanks for the contribution, just some mainly documentaiton related comments. Please also fix the build and DCO.

[lolodomo]

This PR is in a wrong state, DCO error and even more important the build failed.
I try to trigger a rebuild.

[lolodomo]

You need to run spotless: mvn spotless:apply

[appzer]

You need to run spotless: mvn spotless:apply

already done!
i made this locally and uploaded it afterwards without success. Can someone from the authorized members run and check it again themselves? Thanks very much.
Regards Kevin

[lsiepel]

The last commit you tried to push (spotless) was probably rejected because your branch is 1753 commits behind and has some merge conflicts that need manual interaction. I just triedd to merge your branch from current main, but i don;t have write permission to your branch.
You could do the same by merging openhab main into your fork at github, into your local fork, into your feature branch. The conflict is in the addon.xml
My vscode wen nuts due to the amount of commits and i had to manually merge in ~400 commits per step to get it up to date.
Let me know if you need any help.

[appzer]

@lsiepel how i can give you permission to my branch. I dont know what i have to do!
Thanks Kevin

[lsiepel]

@lsiepel how i can give you permission to my branch. I dont know what i have to do! Thanks Kevin

https://docs.github.com/en/issues/planning-and-tracking-with-projects/managing-your-project/managing-access-to-your-projects#granting-a-collaborator-access-to-your-project

[appzer]

@lsiepel how i can give you permission to my branch. I dont know what i have to do! Thanks Kevin

https://docs.github.com/en/issues/planning-and-tracking-with-projects/managing-your-project/managing-access-to-your-projects#granting-a-collaborator-access-to-your-project

done

Please let me know if and how I can help you.

Thank you
Kevin

[lsiepel]

Merged upstream into your reposity. Still some issues that you need to look at:

1. DCO, see here: https://github.com/openhab/openhab-addons/pull/14578/checks?check_run_id=30987719374
2. Spotless / build fix.
3. Open review comments.

[appzer]

Merged updatream into your reposity. Still some issues that you need to look at:

1. DCO, see here: https://github.com/openhab/openhab-addons/pull/14578/checks?check_run_id=30987719374
2. Spotless / build fix.
3. Open review comments.

How to solve this

[lsiepel]

@appzer sorry, somehow i edited your post instead of quoting, reverted this and here is the quote ;-)

How to solve this?

1. DCO, see here: https://github.com/openhab/openhab-addons/pull/14578/checks?check_run_id=30987719374

There is a description how to fix it at the link

2. Spotless / build fix.

mvn spotless:apply for reference: https://www.openhab.org/docs/developer/guidelines.html#code-format

3. Open review comments.

Don't think this needs explenation.

Please let me know if you can proceed or if you need anything else.

[appzer]

@appzer sorry, somehow i edited your post instead of quoting, reverted this and here is the quote ;-)

How to solve this?

1. DCO, see here: https://github.com/openhab/openhab-addons/pull/14578/checks?check_run_id=30987719374

There is a description how to fix it at the link

2. Spotless / build fix.

mvn spotless:apply for reference: https://www.openhab.org/docs/developer/guidelines.html#code-format

3. Open review comments.

Don't think this needs explenation.

Please let me know if you can proceed or if you need anything else.

Hi @lsiepel,

Unfortunately I can't figure it out! Can you take over this module and make it public?

Thank you
Kevin

[lsiepel]

ver this module and make it public?

Thank you

I rather give you support so that we can fix it together. Can you try to explain what you did and where you struggle? Maybe best to try to fix 2 and 3 first. The DCO can be fixed at any time.

[appzer]

ver this module and make it public?
Thank you

I rather give you support so that we can fix it together. Can you try to explain what you did and where you struggle? Maybe best to try to fix 2 and 3 first. The DCO can be fixed at any time.

How i can use a CLI? I only use the web interface.

[lsiepel]

ver this module and make it public?
Thank you

I rather give you support so that we can fix it together. Can you try to explain what you did and where you struggle? Maybe best to try to fix 2 and 3 first. The DCO can be fixed at any time.

How i can use a CLI? I only use the web interface.

AFAIK these steps can only be done from the IDE/CLI, not the webinterface.

Are you using vs code as IDE? Within vs code you can open a terminal/CLI to start maven with different options. The one mentioned is to run mvn with the spotless plugin.

Vs code documentation is here
https://www.openhab.org/docs/developer/ide/vscode.html

[appzer]

ver this module and make it public?
Thank you

I rather give you support so that we can fix it together. Can you try to explain what you did and where you struggle? Maybe best to try to fix 2 and 3 first. The DCO can be fixed at any time.

How i can use a CLI? I only use the web interface.

AFAIK these steps can only be done from the IDE/CLI, not the webinterface.

Are you using vs code as IDE? Within vs code you can open a terminal/CLI to start maven with different options. The one mentioned is to run mvn with the spotless plugin.

Vs code documentation is here https://www.openhab.org/docs/developer/ide/vscode.html

Hi @lsiepel

i only use the web interface.
I give you write access to my repository, i hope you get the update published.
https://github.com/Pushsafer/openhab-addons

Kind Regards
Kevin

[lsiepel]

All branches are up to date. Just made a trivial change to verify all is fine. But somehow CI is complaining about spotless, while locally builds are fine and spotless does not find anything to fix.

What am i missing here?

[lsiepel]

Ok. Thanks! LGTM.

Some weird stuff going on. CI complained about spotless, locally i had no problem. So ended up in removing the problematic file and adding it again. Now CI builds fine :-s

Anyway, as i performed these trivial changes to trigger CI i doubt i should merge this. Maybe some other @openhab/add-ons-maintainers can merge this, i already reviewd the code.