[gce] Ensure ressources are freed#17949
Merged
lsiepel merged 13 commits intoopenhab:mainfrom Feb 18, 2025
Merged
Conversation
clinique
added
bug
clinique
added
additional testing preferred
A bit of code revamp Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
clinique
removed
the
additional testing preferred
lsiepel
requested changes
Feb 18, 2025
Contributor
lsiepel
left a comment
lsiepel
left a comment
There was a problem hiding this comment.
Some comments and a question. Might be fine, but to me this seems strange.
...inding.gce/src/main/java/org/openhab/binding/gce/internal/handler/Ipx800DeviceConnector.java
Outdated
Show resolved
Hide resolved
...inding.gce/src/main/java/org/openhab/binding/gce/internal/handler/Ipx800DeviceConnector.java
Outdated
Show resolved
Hide resolved
...inding.gce/src/main/java/org/openhab/binding/gce/internal/handler/Ipx800DeviceConnector.java
Show resolved
Hide resolved
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
* Ensure ressources are freed. A bit of code revamp Signed-off-by: clinique <gael@lhopital.org>
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
* Ensure ressources are freed. A bit of code revamp Signed-off-by: clinique <gael@lhopital.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #17940
Global code review