[tellstick] Add null annotations by lsiepel · Pull Request #17974 · openhab/openhab-addons

lsiepel · 2024-12-24T20:09:58Z

Add null annotations
Fixed most warnings as a result of adding null annotations.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

jlaur

Thanks for fixing the annotations and warnings. Can you rebase to make the dependency upgrades disappear? 🙂

...ick/src/main/java/org/openhab/binding/tellstick/internal/conf/TelldusLocalConfiguration.java

...tick/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java

...k/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreDeviceController.java

...tick/src/main/java/org/openhab/binding/tellstick/internal/live/TelldusLiveBridgeHandler.java

...k/src/main/java/org/openhab/binding/tellstick/internal/live/TelldusLiveDeviceController.java

…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

…b/binding/tellstick/internal/live/TelldusLiveDeviceController.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

jlaur · 2025-01-06T23:02:05Z

@lsiepel - unfortunately I missed to merge this before New Year. There are now some conflicts to resolve, probably because of #18015.

lsiepel · 2025-02-19T10:38:52Z

@lsiepel - unfortunately I missed to merge this before New Year. There are now some conflicts to resolve, probably because of #18015.

Should be good now.

jlaur

When checking changed files since my last review iteration, I found one bug. Other than that LGTM - I assume it's tested and ready to go?

...tick/src/main/java/org/openhab/binding/tellstick/internal/live/TelldusLiveBridgeHandler.java

...k/src/main/java/org/openhab/binding/tellstick/internal/live/TelldusLiveDeviceController.java

...tick/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java

…b/binding/tellstick/internal/live/TelldusLiveDeviceController.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

lsiepel · 2025-02-19T11:57:43Z

When checking changed files since my last review iteration, I found one bug. Other than that LGTM - I assume it's tested and ready to go?

No functionality has changed, i think it is ready to go, but i lack a tellstick so it was not very well tested.

jlaur

Only one thing left from new commit.

jlaur · 2025-02-19T12:14:59Z

...tick/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java

-        eventHandler = new TellstickEventHandler(deviceList);
+        TellstickEventHandler eventHandler = this.eventHandler = new TellstickEventHandler(deviceList);
        eventHandler.addListener(this);
+        this.eventHandler = eventHandler;


This is not needed anymore, since already assigned in line 180.

Suggested change

this.eventHandler = eventHandler;

I forgot about this when merging, but it's quite minor.

jlaur · 2025-02-19T12:19:13Z

@jannegpriv, @ulfwin - I found some relatively recent PR's from you for this binding, perhaps you'd like to give this a test run if @lsiepel could do a 4.3.x build for production use?

lsiepel · 2025-02-19T12:21:54Z

@jannegpriv, @ulfwin - I found some relatively recent PR's from you for this binding, perhaps you'd like to give this a test run if @lsiepel could do a 4.3.x build for production use?

Not sure if this is going to work, but give it a try:
https://1drv.ms/u/s!AnMcxmvEeupwj5MKc6wj8aRuFMVBZg?e=mlbFFi

jlaur · 2025-02-19T12:29:07Z

Not sure if this is goping to work, but give it a try:

It probably would need to be cherry-picked on top of 4.3.x with the recent karaf upgrade etc. Let's wait and see if there will be a volunteer tester before going through this effort. 😉

ulfwin · 2025-02-19T18:36:52Z

I can give it a try, if I get some help. It seems to be a general change, so the fact that I'm not using the Telldus Live bridge is fine, right?

Also, I guess I need to update to the latest openhab? I would need to do that in a controlled manner, so it might take some extra time.

jlaur · 2025-02-20T21:02:51Z

Also, I guess I need to update to the latest openhab?

Which version are you running now? It should be easy to create a JAR for 4.3.

jlaur

LGTM. Let's give it some mileage with M1 and in parallel see if we can have it tested with 4.3.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

lsiepel added 2 commits December 24, 2024 20:15

Update async-http-client

75b5110

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

Add annotations and fix some warnings

f6e7960

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

lsiepel requested a review from a team as a code owner December 24, 2024 20:09

jlaur requested changes Dec 28, 2024

View reviewed changes

lsiepel and others added 5 commits December 28, 2024 14:57

Update bundles/org.openhab.binding.tellstick/src/main/java/org/openha…

f62861b

…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

Update bundles/org.openhab.binding.tellstick/src/main/java/org/openha…

1329b3e

…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

Update bundles/org.openhab.binding.tellstick/src/main/java/org/openha…

e83c197

…b/binding/tellstick/internal/live/TelldusLiveDeviceController.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

Merge branch 'openhab:main' into tellstick-null-annotations

b5baad7

Fix review comments

d718cb6

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

Merge branch 'main' into tellstick-null-annotations

c2e35e3

jlaur requested changes Feb 19, 2025

View reviewed changes

lsiepel and others added 3 commits February 19, 2025 12:52

Update bundles/org.openhab.binding.tellstick/src/main/java/org/openha…

2605c8b

…b/binding/tellstick/internal/live/TelldusLiveDeviceController.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

Update bundles/org.openhab.binding.tellstick/src/main/java/org/openha…

7f33244

…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>

Fix review comment

df5622a

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

jlaur requested changes Feb 19, 2025

View reviewed changes

jlaur approved these changes Feb 23, 2025

View reviewed changes

jlaur merged commit 7224333 into openhab:main Feb 23, 2025
2 checks passed

jlaur added this to the 5.0 milestone Feb 23, 2025

lsiepel deleted the tellstick-null-annotations branch February 23, 2025 17:09

matgroe pushed a commit to matgroe/openhab-addons that referenced this pull request Feb 24, 2025

[tellstick] Add null annotations (openhab#17974)

0e61193

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

phenix1990 pushed a commit to phenix1990/openhab-addons that referenced this pull request Jul 31, 2025

[tellstick] Add null annotations (openhab#17974)

6285b13

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

Uh oh!

Comments

Conversation

lsiepel commented Dec 24, 2024

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlaur commented Jan 6, 2025

Uh oh!

lsiepel commented Feb 19, 2025

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lsiepel commented Feb 19, 2025

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

jlaur Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

jlaur Feb 23, 2025

Choose a reason for hiding this comment

Uh oh!

jlaur commented Feb 19, 2025

Uh oh!

lsiepel commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jlaur commented Feb 19, 2025

Uh oh!

ulfwin commented Feb 19, 2025

Uh oh!

jlaur commented Feb 20, 2025

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lsiepel commented Feb 19, 2025 •

edited

Loading