Conversation
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
marvkis
reviewed
Jan 6, 2025
Contributor
marvkis
left a comment
marvkis
left a comment
There was a problem hiding this comment.
Hi,
I have had a quick look at the changes. Filling in return values could be dangerous as it could change the code flow in an unexpected way. I tried to have a closer look at the parts and found one point where it might skip relevant attributes - could you change this?
Thanks,
Chris
...hab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/schema/ApiPageParser.java
Outdated
Show resolved
Hide resolved
lsiepel
commented
Jan 6, 2025
...hab.binding.tacmi/src/main/java/org/openhab/binding/tacmi/internal/schema/ApiPageParser.java
Outdated
Show resolved
Hide resolved
…nding/tacmi/internal/schema/ApiPageParser.java Signed-off-by: lsiepel <leosiepel@gmail.com>
wborn
approved these changes
Jan 9, 2025
GearrelW
pushed a commit
to GearrelW/openhab-addons
that referenced
this pull request
Jan 12, 2025
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing a tacmi related PR, i noticed these errors and fixed them right away.
(empty control statements, empty line and naming convention.