Skip to content

[digiplex] Fix SAT errors #18047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlaur merged 1 commit into from
Jan 6, 2025
Merged

[digiplex] Fix SAT errors #18047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...giplex/src/main/java/org/openhab/binding/digiplex/internal/DigiplexAreaConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,15 @@
*/
package org.openhab.binding.digiplex.internal;

import org.eclipse.jdt.annotation.NonNullByDefault;

/**
* The {@link DigiplexAreaConfiguration} class contains fields mapping area configuration parameters.
*
* @author Robert Michalak - Initial contribution
*/
@NonNullByDefault
public class DigiplexAreaConfiguration {

public int refreshPeriod;
public int refreshPeriod = 60;
}
7 changes: 5 additions & 2 deletions ...plex/src/main/java/org/openhab/binding/digiplex/internal/DigiplexBridgeConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,16 @@
*/
package org.openhab.binding.digiplex.internal;

import org.eclipse.jdt.annotation.NonNullByDefault;

/**
* The {@link DigiplexBridgeConfiguration} class contains fields mapping bridge configuration parameters.
*
* @author Robert Michalak - Initial contribution
*/
@NonNullByDefault
public class DigiplexBridgeConfiguration {

public String port;
public int baudrate;
public String port = "";
public int baudrate = 2400;
}
2 changes: 1 addition & 1 deletion ...ex/src/main/java/org/openhab/binding/digiplex/internal/handler/DigiplexBridgeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public DigiplexBridgeHandler(Bridge bridge, SerialPortManager serialPortManager)
@Override
public void initialize() {
config = getConfigAs(DigiplexBridgeConfiguration.class);
if (config.port == null) {
if (config.port.isBlank()) {
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.OFFLINE.CONFIGURATION_ERROR, "Port must be set!");
return;
}
Expand Down