Skip to content

[insteon] Fix legacy all link broadcast message not processed #18049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsiepel merged 1 commit into from
Jan 6, 2025
Merged

[insteon] Fix legacy all link broadcast message not processed #18049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ding.insteon/src/main/java/org/openhab/binding/insteon/internal/InsteonLegacyBinding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ public void disconnected() {

private void handleInsteonMessage(Msg msg) throws FieldException {
InsteonAddress toAddr = msg.getInsteonAddress("toAddress");
if (!msg.isBroadcast() && !driver.isMsgForUs(toAddr)) {
if (!msg.isBroadcast() && !msg.isAllLinkBroadcast() && !driver.isMsgForUs(toAddr)) {
// not for one of our modems, do not process
return;
}
Expand Down
4 changes: 2 additions & 2 deletions ...nding.insteon/src/main/java/org/openhab/binding/insteon/internal/device/LegacyDevice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ public long processRequestQueue(long timeNow) {
if (qe == null) {
return 0L;
}
if (!qe.getMsg().isBroadcast()) {
if (!qe.getMsg().isAllLinkBroadcast()) {
logger.debug("qe taken off direct: {} {}", qe.getFeature(), qe.getMsg());
lastQueryTime = timeNow;
// mark feature as pending
Expand Down Expand Up @@ -382,7 +382,7 @@ public void enqueueDelayedMessage(Msg msg, LegacyDeviceFeature feature, long del
synchronized (mrequestQueue) {
mrequestQueue.add(new QEntry(feature, msg, now + delay));
}
if (!msg.isBroadcast()) {
if (!msg.isAllLinkBroadcast()) {
msg.setQuietTime(QUIET_TIME_DIRECT_MESSAGE);
}
logger.trace("enqueing direct message with delay {}", delay);
Expand Down